use titlecase, not uppercase, for ucfirst #21967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
added
strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate from questions of what
ucfirstshould be called or whether it should even exist (#21910), the current behavior was clearly wrong (using uppercase rather than titlecase) for Unicode. This PR fixes that.Most users won't notice any difference, since titlecase and uppercase are almost always the same. (Of the 2621 Unicode characters that have case at all, only 12 have a distinct titlecase.)
The Julia
ucfirstfunction seems to have been modeled on the Perl ucfirst function, which uses titlecase. However, when the Juliaucfirstfunction was written, we didn't have access to the Unicode tables needed to implement titlecase.