Minor clean up in symbol allocation and lookup #22012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove `volatile`.
The thread safety is provided by atomics and not volatile
* Update comment.
We are now relying on the GC bits to be `GC_OLD_MARKED` in order to not update it's metadata
similar to other ptrfree permgen objects allocations.
vtjnash
approved these changes
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
volatile.The thread safety is provided by atomics and not volatile
Update comment.
We are now relying on the GC bits to be
GC_OLD_MARKEDin order to not update it's metadatasimilar to other ptrfree permgen objects allocations.
Also marking the
acquireload asconsumethough it's unclear when it can get a implementable semantic in the C/C++ standard and be implemented differently fromacquirein compilers....