Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for #17003 #22081

Merged
merged 2 commits into from
May 26, 2017
Merged

add test for #17003 #22081

merged 2 commits into from
May 26, 2017

Conversation

KristofferC
Copy link
Member

Closes #17003

@KristofferC KristofferC added backport pending 0.6 test This change adds or pertains to unit tests labels May 26, 2017
@tkelman
Copy link
Contributor

tkelman commented May 26, 2017

please use a more descriptive commit message, summarize what the issue is about in at least a few words

@KristofferC
Copy link
Member Author

I don't have a more descriptive test message. "Test that this random piece of code that used to crash doesn't crash anymore?"

@KristofferC
Copy link
Member Author

Lol I put the test in base/inference.jl

@KristofferC KristofferC merged commit 8c19eec into master May 26, 2017
@KristofferC KristofferC deleted the kc/test_17003 branch May 26, 2017 21:34
tkelman pushed a commit that referenced this pull request Jun 3, 2017
@KristofferC @tkelman
add test for code that used to crash, #17003 (#22081)
2ad58d4 
(cherry picked from commit 8c19eec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KristofferC @tkelman