Test if selfmem can write to RX page #22127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added backport label. Not sure how cleanly this can be backported to 0.5. |
Keno
approved these changes
May 30, 2017
|
A local cherry-pick attempt shows no conflict so this should be backportable to 0.5. |
alyst
reviewed
May 30, 2017
src/cgmemmgr.cpp
Outdated
| static int self_mem_fd = -1; | ||
|
|
||
| static int init_self_mem() | ||
| // Do not call this direction. |
Also open only one `/proc/self/mem`. There are apparently two instances of `RTDyldMemoryManagerJL` created. Fix #22082
yuyichao
force-pushed
the
yyc/codegen/memmgr
branch
from
406408e
to
ca22001
Compare
|
I take the approve as tested on 4.12-rc* kernel? |
|
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also open only one
/proc/self/mem.There are apparently two instances of
RTDyldMemoryManagerJLcreated.Fix #22082
@Keno for testing.