fix some macro expander issues with new 0.6 syntax #22166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
backport pending 0.6
bugfix
JeffBezanson
force-pushed
the
jb/macrofixes
branch
2 times, most recently
from
6bf8906
to
d54e2bc
Compare
|
This also fixes #19351🎉 |
|
The various helper functions sure could use comments describing what they're doing.
would be good to add a test for that as well then, if not exactly covered |
JeffBezanson
force-pushed
the
jb/macrofixes
branch
from
d54e2bc
to
60675d2
Compare
|
Done and done. |
vtjnash
reviewed
Jun 1, 2017
| macro generated(f) | ||
| isa(f, Expr) || error("invalid syntax; @generated must be used with a function definition") | ||
| if f.head === :function || (isdefined(:length) && f.head === :(=) && length(f.args) == 2 && f.args[1].head == :call) | ||
| if f.head === :function || (isdefined(:length) && f.head === :(=) && length(f.args) == 2 && | ||
| eventually_call(f.args[1])) |
There was a problem hiding this comment.
use existing is_short_function_def instead
vtjnash
approved these changes
Jun 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22135, fixes #22122, fixes #22026, fixes #21581
Now also #16096