Generalize UnitRange->AbstractUnitRange in sparse indexing #22175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are any examples of code that looks like #22173 in the existing benchmark set? Seems like we would have noticed it when comparing 0.5 to 0.6 if there had been. |
|
This is brilliant, thanks @timholy ! |
KristofferC
added
potential benchmark
timholy
added a commit
to JuliaCI/BaseBenchmarks.jl
that referenced
this pull request
Jun 1, 2017
|
@tkelman, we do now: JuliaCI/BaseBenchmarks.jl#77 |
timholy
added a commit
to JuliaCI/BaseBenchmarks.jl
that referenced
this pull request
Jun 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial change with a 50x performance benefit. Fixes #22173. CC @mkborregaard.