Use libgcc dlls from build system compiler for windows binaries #22197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of opensuse
tkelman
added
backport pending 0.4
building
tkelman
changed the title
tkelman
added a commit
that referenced
this pull request
Jun 6, 2017
instead of opensuse (cherry picked from commit 5aa15ff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of opensuse
yep this broke again, xref #22189, #18059, #10244 and related
DO NOT MERGE this until the windows buildbots have been upgraded from gcc 4.9 to 5.4, otherwise it would break ZMQ.jl, Ipopt.jl, and othersdoneBefore opensuse goes and breaks this again the next time, we should do some work out in packages to download and repackage specific known-working versions of what winrpm is downloading, and upload the dlls (in a simpler format, just tar.gz or something like that) to github releases where the julia packages can download a constant known-working version. The upstream repo being out of our control has been fragile, mostly with compiler upgrades and configuration changes happening at inopportune times like during release candidates.