Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DomainError when parsing DateTime #22198

Merged
merged 2 commits into from
Jun 5, 2017
Merged

Fix DomainError when parsing DateTime #22198

merged 2 commits into from
Jun 5, 2017

Conversation

omus
Copy link
Member

@omus omus commented Jun 2, 2017

Fixes #22100

@KristofferC KristofferC added backport pending 0.6 bugfix This change fixes an existing bug dates Dates, times, and the Dates stdlib module labels Jun 2, 2017
fredrikekre
fredrikekre reviewed Jun 2, 2017
View reviewed changes
test/dates/io.jl
@@ -432,3 +432,14 @@ end

# Issue #21504
@test isnull(tryparse(Dates.Date, "0-1000"))

# Issue #22100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps make a testset of this issue tests? Simplifies for whoever converts this file to @testsets later on

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds resasonable to me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@omus
Copy link
Member Author

omus commented Jun 5, 2017

32-bit failure on Appveyor is unrelated. Should I trigger a new build?

@KristofferC
Copy link
Member

I don't think that is needed.

@KristofferC KristofferC merged commit abf3bce into master Jun 5, 2017
@omus omus deleted the cv/dates-domain-error branch June 5, 2017 17:17
tkelman pushed a commit that referenced this pull request Jun 6, 2017
@omus @tkelman
Fix DomainError when parsing DateTime (#22198)
7c0a1b7 
* Fix DomainError when parsing DateTime

* Converted tests into a testset

(cherry picked from commit abf3bce)
@bachdavi bachdavi mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug dates Dates, times, and the Dates stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@omus @KristofferC @quinnj @fredrikekre @tkelman