Backport LLVM patches to fix AVX on i686 #22205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in the patch that fixes #19976 causing encoding error on 32bit x86 and segfault when AVX/AVX2 is enabled. Ref LLVM bug report https://bugs.llvm.org//show_bug.cgi?id=29010 LLVM commit llvm-mirror/llvm@83260f2 Also ref where I saw this issue in #21849 (comment)
yuyichao
added
backport pending 0.6
upstream
Keno
approved these changes
Jun 3, 2017
tkelman
pushed a commit
that referenced
this pull request
Jun 6, 2017
This fixes a bug in the patch that fixes #19976 causing encoding error on 32bit x86 and segfault when AVX/AVX2 is enabled. Ref LLVM bug report https://bugs.llvm.org//show_bug.cgi?id=29010 LLVM commit llvm-mirror/llvm@83260f2 Also ref where I saw this issue in #21849 (comment) (cherry picked from commit 5a42474) ref #22205
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the patch that fixes #19976 causing encoding error on 32bit x86
and segfault when AVX/AVX2 is enabled.
Ref LLVM bug report https://bugs.llvm.org//show_bug.cgi?id=29010
LLVM commit llvm-mirror/llvm@83260f2
Also ref where I saw this issue in #21849 (comment)
Should be backported to 0.6 since the bad patch is included in the 0.6 branch. Win32 LLVM binary will need a rebuild. (AppVeyor didn't hit this issue in #21849 since it doesn't support AVX2).