incremental serialize: restore recache order back to original

[vtjnash]

the commit fix for #265 reshuffled this order, but that was wrong
the correctness of jl_recache_other has since been fixed,
permitting this to go back to the correct original order

fix #22171

[tkelman]

tests?

[vtjnash]

I understand that this order is more correct (that's why it was done this way in v0.5), I just don't yet know how to construct counter-examples (like SIMD.jl triggered in #22171) to use as tests.

[ararslan]

You could do something like this maybe to test:

mktempdir() do dir
    f = tempname()
    write(f, """
        Pkg.init("$dir")
        Pkg.clone("https://github.com/eschnett/SIMD.jl.git")
        Pkg.checkout("SIMD", "a4256db194e36a48922d28c3d702cb27d20a925d")
        using SIMD
        exit(isdefined(Main, :SIMD) ? 0 : 1)
    """)
    cmd = `$(Base.julia_cmd()) --startup-file=no --precompiled=yes --compilecache=yes $f`
    @test success(pipeline(cmd, stdout=STDOUT, stderr=STDERR))
end

I haven't checked this particular code, but something like it may work

[vtjnash]

The code for the tests needs to be versioned, and preferably a MWE. PkgEval will running tests on this functionality across a large range of code "in the wild".