add some doctest to test #22287
add some doctest to test #22287
Conversation
KristofferC
added
backport pending 0.6
docs
doc/src/stdlib/test.md
Outdated
| julia> @test foo("bar") == 9 | ||
| Test Passed | ||
| Expression: foo("bar") == 9 | ||
| Evaluated: 9 == 9 | ||
|
|
There was a problem hiding this comment.
are all the extra blank lines needed for this to pass?
There was a problem hiding this comment.
They exist in the output.
There was a problem hiding this comment.
Not sure if you could call it a bug but it is not pretty at least.
There was a problem hiding this comment.
looks wrong, anyone know what's causing it?
There was a problem hiding this comment.
diff --git a/base/test.jl b/base/test.jl
index c841552..25ab49f 100644
--- a/base/test.jl
+++ b/base/test.jl
@@ -69,9 +69,9 @@ struct Pass <: Result
value
end
function Base.show(io::IO, t::Pass)
- print_with_color(:green, io, "Test Passed\n"; bold = true)
+ print_with_color(:green, io, "Test Passed"; bold = true)
if !(t.orig_expr === nothing)
- print(io, " Expression: ", t.orig_expr)
+ print(io, "\n Expression: ", t.orig_expr)
end
if t.test_type == :test_throws
# The correct type of exception was thrown?
|
Can we merge this? |
|
Probably. |
KristofferC
force-pushed
the
kc/doctest_help
branch
from
1b49bcb
to
4ef09d3
Compare
|
Pushed @fredrikekre commit and updated doctests. Should be good to go. |
| @@ -68,23 +68,25 @@ julia> @test foo(:cat) == 1 | |||
| Error During Test | |||
| Test threw an exception of type MethodError | |||
| Expression: foo(:cat) == 1 | |||
| MethodError: `length` has no method matching length(::Symbol) | |||
There was a problem hiding this comment.
should this block go in the same jldoctest set?
There was a problem hiding this comment.
No because the stacktrace is very weird from how Documenter evaluates things in its own module.
doc/src/stdlib/test.md
Outdated
| julia> @test_throws MethodError foo(:cat) | ||
| Test Passed | ||
| Expression: foo(:cat) | ||
| Evaluated: MethodError | ||
|
|
There was a problem hiding this comment.
should this blank line still be here?
doc/src/stdlib/test.md
Outdated
| in do_test at test.jl:53 | ||
| Test Failed | ||
| Expression: 1 ≈ 0.999999 | ||
| Evaluated: 1 isapprox 0.999999 |
There was a problem hiding this comment.
likely needs updating for #22296
There was a problem hiding this comment.
Thanks, I messed up when running the doctests (they didnt actually get run) so I will rebase master and make sure everything passes.
There was a problem hiding this comment.
Actually this was corrected as part of #22315
KristofferC
force-pushed
the
kc/doctest_help
branch
from
4ef09d3
to
b909ee5
Compare
|
Doctests for this file now passes locally. |
KristofferC
force-pushed
the
kc/doctest_help
branch
from
b909ee5
to
a478a0a
Compare
* fix spurious newlines in Base.Test printing * add some doctest to test (cherry picked from commit 2796b40)
* fix spurious newlines in Base.Test printing * add some doctest to test (cherry picked from commit 2796b40)
* fix spurious newlines in Base.Test printing * add some doctest to test (cherry picked from commit 2796b40)
No description provided.