Get rid of legacy gc use markers #22419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
approved these changes
Jun 18, 2017
src/ccall.cpp
Outdated
| @@ -2081,7 +2066,6 @@ jl_cgval_t function_sig_t::emit_a_ccall( | |||
|
|
|||
| // Mark GC use before **and** after the ccall to make sure the arguments | |||
There was a problem hiding this comment.
There's a few comment that can be removed too. e.g. here and the one before CreateTrap below.
|
Hmmm, I'm seeing a new illegal |
|
The new LLVM 4.0/5.0 failure is fixed by https://reviews.llvm.org/D34335. I'll wait for more comment there before submitting it as a patch here unless someone really needs it..... I can confirm that this fixes the extra GC roots as well as a few different cases I've noticed later. (e.g. with |
yuyichao
added
compiler:codegen
They are not needed any more in this brave new world. Fixes #22415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not needed any more in this brave new world.
Fixes #22415