A few inference/codegen optimizations #22425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Jun 18, 2017
src/codegen.cpp
Outdated
| JL_GC_POP(); | ||
| return true; | ||
| } | ||
| else if (((jl_datatype_t*)sty)->name == jl_array_typename) { |
There was a problem hiding this comment.
Check if sty is a datatype first
yuyichao
force-pushed
the
yyc/codegen/sizeof
branch
2 times, most recently
from
f5b4ba8
to
1ecf678
Compare
ararslan
added
compiler:codegen
|
Add a codegen test? |
yuyichao
force-pushed
the
yyc/codegen/sizeof
branch
from
1ecf678
to
56cc72d
Compare
yuyichao
force-pushed
the
yyc/codegen/sizeof
branch
from
56cc72d
to
55a2eb2
Compare
|
Would also be good to have tests for the sizeof tfunc. |
|
Yes, trying to add that... |
yuyichao
force-pushed
the
yyc/codegen/sizeof
branch
from
55a2eb2
to
53af93b
Compare
|
Rebased on top of #22455 (for |
tkelman
reviewed
Jun 21, 2017
test/inference.jl
Outdated
|
|
||
| function test_const_return(f::ANY, t::ANY, val::ANY) | ||
| linfo = get_linfo(f, t) | ||
| # If converage is not enabled, make the check strict by requiring constant ABI |
yuyichao
force-pushed
the
yyc/codegen/sizeof
branch
from
53af93b
to
3668fdb
Compare
* Infer `Core.sizeof` constant results * Inline `Core.sizeof` in codegen * Optimize `jl_string_str` Fix #22422
yuyichao
force-pushed
the
yyc/codegen/sizeof
branch
from
3668fdb
to
0f4c537
Compare
vtjnash
added a commit
that referenced
this pull request
Jun 23, 2017
vtjnash
added a commit
that referenced
this pull request
Jun 23, 2017
vtjnash
added a commit
that referenced
this pull request
Jun 23, 2017
quinnj
pushed a commit
that referenced
this pull request
Jun 24, 2017
DrTodd13
pushed a commit
to IntelLabs/julia
that referenced
this pull request
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core.sizeofconstant resultsCore.sizeofin codegenjl_string_strFix #22422