only store JIT function names, not full prototypes #22678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
approved these changes
Jul 5, 2017
| @@ -1313,9 +1314,8 @@ static jl_method_instance_t *jl_get_unspecialized(jl_method_instance_t *method) | |||
|
|
|||
| // this compiles li and emits fptr | |||
| extern "C" | |||
| jl_generic_fptr_t jl_generate_fptr(jl_method_instance_t *li, void *_F, size_t world) | |||
| jl_generic_fptr_t jl_generate_fptr(jl_method_instance_t *li, const char *F, size_t world) | |||
There was a problem hiding this comment.
fname for consistency? Happens in lots of places.
There was a problem hiding this comment.
We're kinda fuzzy on F/function/llvmf/specf/f naming too...
There was a problem hiding this comment.
yeah, we just kind of pick whichever one is appropriate given whichever other variables needed to also appear. I'm not sure it's worth too much effort to try to do a sweep through and make them that much more consistent. I'm planning on eliminating these names anyways and switching just to using the fptr field directly. This PR is just part of a transitional state to slowly decouple and remove that global state.
this saves a bit of memory and shaves a bit off of startup time
|
really should have run nanosoldier here before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this saves a bit of memory and shaves a bit off of startup time