RFC: slightly refactor representation of generated methods #22744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
force-pushed
the
jb/isstaged
branch
from
4340084 to
9afb66d
Compare
- Remove `isstaged` field. In the future, a method will not be inherently staged but rather have a generator available or not. - Always use meth.generator.inferred to access generator code. - Make meth.source always refer to normal code, set to NULL for generated methods. This allows us to have both in the future.
JeffBezanson
force-pushed
the
jb/isstaged
branch
from
9afb66d to
9a41c33
Compare
|
Reverts 8b708b4 Lgtm, but I never really saw the point to that issue originally either. |
|
Reopen #18838? |
|
Nah, that issue will only get less valid, since my plan is to put a normal implementation in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small step in the direction of having fallbacks for
@generatedfunctions --- or, put differently, treating@generatedmethods as just optimizations of normal methods.isstagedfield. In the future, a method will not be inherently staged but rather have a generator available or not.