Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Cygwin on AppVeyor instead of MSYS2 #22821

Merged
merged 4 commits into from
Jul 17, 2017
Merged

Switch to using Cygwin on AppVeyor instead of MSYS2 #22821

merged 4 commits into from
Jul 17, 2017

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Jul 15, 2017

AppVeyor is the only place where MSYS2 is somewhat supported at the moment, a from-scratch source build on MSYS2 has not worked since some time between 0.4 and 0.5 (maybe even before that). The Windows buildbots cross-compile from Cygwin and that's been the recommended method for building on Windows for a few years now. Making AppVeyor consistent with that means one less possible build environment to have to worry about. And it'll unblock #22189.

(close #17223 as it doesn't work lately)

tkelman added 3 commits July 15, 2017 06:02
this will match what the buildbots use to make binaries
(gcc 5 pthreads, c++11 abi instead of gcc 4 win32 threads, old abi)

use cygpath_w around llvm-size call for make build-stats
uses c++11 abi now

delete old checksums
msys2 is not actively supported

macports and homebrew now have mingw-w64 cross compilers that should work

Vagrantfile doesn't need to set home environment variables any more

[bsd skip]
@musm
Copy link
Contributor

musm commented Jul 15, 2017

👍 this would explain why I haven't been able to get msys2 builds working...

@tkelman
Copy link
Contributor Author

tkelman commented Jul 15, 2017

You can go ahead and report the issues (PR's would be better though). I try msys2 maybe once or twice a year via the vagrantfile here, so don't remember what exactly is broken about it.

@tkelman tkelman mentioned this pull request Jul 15, 2017
@ararslan ararslan added ci Continuous integration system:windows Affects only Windows labels Jul 15, 2017
@tkelman tkelman requested a review from ihnorton July 16, 2017 08:50
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it myself right now, but looks fine. (thanks for correcting the WSL note)

- [x86_64-w64-mingw64 gcc-5.2.0 MacOS-10.10 (105 MB)](https://onedrive.live.com/redir?resid=BCAF288A35FC4406!1601&authkey=!ANpFOoCqFGYTcHM&ithint=file%2cgz)
- [i686-w64-mingw64 gcc-5.2.0 MacOS-10.10 (89 MB)](https://onedrive.live.com/redir?resid=BCAF288A35FC4406!1607&authkey=!AFrL8G5G70iYhUU&ithint=file%2cgz)
- [*-w64-mingw64 gcc-4.9.2 Ubuntu-15.04 (168 MB)](https://onedrive.live.com/redir?resid=BCAF288A35FC4406!1602&authkey=!ABhstrqDG-4zdLo&ithint=file%2cgz)
or [Homebrew](https://brew.sh/). Then run `port install wine wget mingw-w64`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Ports still be recommended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not if your name isn't Jameson.

$arch = "x86_$bits".Replace("x86_32", "i686")
$setup = "setup-$arch.exe".Replace("i686", "x86")

mkdir -Force C:\\cygwin$bits | Out-Null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we make this basepath configurable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean make a variable for it and refer to that everywhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. I get annoyed when scripts stash things under C:, so it would be nice to have an easy way to change. not a huge deal though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can adjust it, but it's a Vagrantfile designed for running in a clean VM...

in the windows Vagrantfile [ci skip]
@mikewl
Copy link
Contributor

mikewl commented Jul 16, 2017

I'll redo my list for msys2 today while I check the build is functioning in bash on Windows.
From memory there were issues with cmake and a workaround which caused it to not find the c compiler.
Also openblas would need the newer version of a file to even start compiling.
The best part of it all was that after its all said and done... The build doesn't even pass the tests.
Will post a bit later once I have my exact list again.

@tkelman tkelman merged commit 66795ba into master Jul 17, 2017
@tkelman tkelman deleted the tk/avtest branch July 17, 2017 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants