Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppress warning for redefining docstrings if the symbol is in Main #23019

Merged
merged 2 commits into from
Jul 31, 2017
Merged

suppress warning for redefining docstrings if the symbol is in Main #23019

merged 2 commits into from
Jul 31, 2017

Conversation

stevengj
Copy link
Member

This fixes #23011.

@stevengj stevengj added the docsystem The documentation building system label Jul 29, 2017
@stevengj
Copy link
Member Author

stevengj commented Jul 29, 2017 •
edited
Loading

Tentatitively marking this for backporting to 0.6, since the existence or nonexistence of a warning doesn't really change the API, and since arguably this is a bug (in 0.6 the intention, per #18725, was not to have warnings for redefinitions in Main).

@stevengj
Copy link
Member Author

Tests pass on Linux Travis, but it timed out (The job exceeded the maximum time limit for jobs, and has been terminated.) while building the documentation.

@JeffBezanson JeffBezanson merged commit 4d4bdc1 into JuliaLang:master Jul 31, 2017
@stevengj stevengj deleted the docstring_redef branch July 31, 2017 21:20
ararslan pushed a commit that referenced this pull request Sep 11, 2017
@stevengj @ararslan
suppress warning for redefining docstrings if the symbol is in Main (#…
5d0c148 
…23019)

suppress warning for redefining docstrings if the symbol is in Main (fixes #23011)

Ref #23019
(cherry picked from commit 4d4bdc1)
ararslan pushed a commit that referenced this pull request Sep 13, 2017
@stevengj @ararslan
suppress warning for redefining docstrings if the symbol is in Main (#…
e1a6d51 
…23019)

suppress warning for redefining docstrings if the symbol is in Main (fixes #23011)

(cherry picked from commit 4d4bdc1)
vtjnash pushed a commit that referenced this pull request Sep 14, 2017
@stevengj @vtjnash
suppress warning for redefining docstrings if the symbol is in Main (#…
26956aa 
…23019)

suppress warning for redefining docstrings if the symbol is in Main (fixes #23011)

(cherry picked from commit 4d4bdc1)
ararslan pushed a commit that referenced this pull request Sep 15, 2017
@stevengj @ararslan
suppress warning for redefining docstrings if the symbol is in Main (#…
0667e76 
…23019)

suppress warning for redefining docstrings if the symbol is in Main (fixes #23011)

(cherry picked from commit 4d4bdc1)
ararslan pushed a commit that referenced this pull request Sep 16, 2017
@stevengj @ararslan
suppress warning for redefining docstrings if the symbol is in Main (#…
7f10a4c 
…23019)

suppress warning for redefining docstrings if the symbol is in Main (fixes #23011)

(cherry picked from commit 4d4bdc1)
ararslan pushed a commit that referenced this pull request Sep 18, 2017
@stevengj @ararslan
suppress warning for redefining docstrings if the symbol is in Main (#…
9db7fd9 
…23019)

suppress warning for redefining docstrings if the symbol is in Main (fixes #23011)

(cherry picked from commit 4d4bdc1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelHatherly MichaelHatherly Awaiting requested review from MichaelHatherly

Assignees
No one assigned
Labels
docsystem The documentation building system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

don't warn about redefining docstrings in Main
3 participants
@stevengj @JeffBezanson @ararslan