deprecate catch <expression>
#23487
Merged
deprecate catch <expression>
#23487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
deprecation
StefanKarpinski
approved these changes
Aug 29, 2017
JeffBezanson
force-pushed
the
jb/catchexpr
branch
from
f19c38f to
8522ff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we allow writing
catch <whatever>, and look at the<whatever>to decide whether it's a variable (catch ex) or an expression to go inside thecatchblock. This is not a good situation. This change deprecates everything exceptcatch var<newline>andcatch var;. That also gives us space to add features like #23418 in the future.I've continued to allow literals right aftercatchsince it's clear that they're not identifiers, but I could go either way on that.addresses #19987