-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add squeeze(f, A, dims) for reductions to drop dims #23500
Conversation
Bump. Good to go? |
Sure. It seems like a reasonable and wanted feature. |
It's been a minute. Let's re-run CI. |
Just realized it should probably have a NEWS item. |
NEWS added. This is good to go once CI passes. |
I won't block this, but it's a little odd how this definition assumes the passed function uses the
|
Maybe it should always pass the function to |
That's a really good point. Even worse is that it would prohibit us from transitioning |
What is the status of this? |
Closing in favor of #33130. |
This simple definition makes it easier to write reductions that drop the dimensions over which they reduce. Fixes #16606, addresses part of the root issue in #22000.