rename --precompiled and --compilecache command line options
#23616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
the
deprecation
vtjnash
reviewed
Sep 8, 2017
doc/src/manual/getting-started.md
Outdated
| -H, --home <dir> Set location of `julia` executable | ||
| --startup-file={yes|no} Load ~/.juliarc.jl | ||
| --handle-signals={yes|no} Enable or disable Julia's default signal handlers | ||
| --sysimg-native-code={yes|no} |
There was a problem hiding this comment.
spell this sysimage-native? (because that's how we spell it in the other option)
doc/src/manual/getting-started.md
Outdated
| --sysimg-native-code={yes|no} | ||
| Use native code from system image if available | ||
| --compiled-modules={yes|no} | ||
| Enable/disable incremental precompilation of modules |
There was a problem hiding this comment.
"Enable or disable"
Seems like we have been writing this out
| @@ -118,6 +120,9 @@ julia [switches] -- [programfile] [args...] | |||
| --color={yes|no} Enable or disable color text | |||
| --history-file={yes|no} Load or save history | |||
|
|
|||
| --depwarn={yes|no|error} Enable or disable syntax and method deprecation warnings ("error" turns warnings into errors) | |||
| --warn-overwrite={yes|no} Enable or disable method overwrite warnings | |||
|
|
|||
| --compile={yes|no|all|min}Enable or disable JIT compiler, or request exhaustive compilation | |||
There was a problem hiding this comment.
appears that we should add a couple spaces, or split this one over multiple lines?
| @@ -109,6 +111,10 @@ static const char opts[] = | |||
| " --color={yes|no} Enable or disable color text\n" | |||
| " --history-file={yes|no} Load or save history\n\n" | |||
|
|
|||
| // error and warning options | |||
| " --depwarn={yes|no|error} Enable or disable syntax and method deprecation warnings (\"error\" turns warnings into errors)\n" | |||
There was a problem hiding this comment.
Should we name this --warn-deprecations? (doesn't need to be the same PR though)
also rearrange help text a bit part of #23054
JeffBezanson
force-pushed
the
jb/cli1
branch
from
00b5fe6 to
d204150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--precompiledbecomes--sysimage-native-code, and--compilecachebecomes--compiled-modules.I also noticed that we were missing newline characters after the warn-overwrite option. I also took the liberty of moving the warning options higher up in the help text, since they're generally more used than the compiler options.
part of #23054