Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Base.Base64 with stdlib Base64 module #24361

Merged
merged 2 commits into from
Oct 28, 2017
Merged

replace Base.Base64 with stdlib Base64 module #24361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a606f1
add Base64 module
bicycle1885 Oct 23, 2017
1db8837
replace Base.Base64 with stdlib Base64 module
JeffBezanson Oct 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
290 changes: 0 additions & 290 deletions base/base64.jl
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions base/deprecated.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1356,6 +1356,11 @@ export conv, conv2, deconv, filt, filt!, xcorr
@deprecate_binding Profile nothing true ", run `using Profile` instead"
@eval @deprecate_moved $(Symbol("@profile")) "Profile" true true

@deprecate_moved base64encode "Base64" true true
@deprecate_moved base64decode "Base64" true true
@deprecate_moved Base64EncodePipe "Base64" true true
@deprecate_moved Base64DecodePipe "Base64" true true

# PR #21709
@deprecate cov(x::AbstractVector, corrected::Bool) cov(x, corrected=corrected)
@deprecate cov(x::AbstractMatrix, vardim::Int, corrected::Bool) cov(x, vardim, corrected=corrected)
Expand Down
4 changes: 0 additions & 4 deletions base/exports.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,10 +715,6 @@ export
# strings and text output
ascii,
base,
base64encode,
base64decode,
Base64EncodePipe,
Base64DecodePipe,
startswith,
bin,
bitstring,
Expand Down
4 changes: 2 additions & 2 deletions base/multimedia.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ that binary data is base64-encoded as an ASCII string.
"""
stringmime(m::MIME, x) = istextmime(m) ? reprmime(m, x) : _binstringmime(m, x)

_binstringmime(m::MIME, x) = base64encode(verbose_show, m, x)
_binstringmime(m::MIME, x::Vector{UInt8}) = base64encode(write, x)
_binstringmime(m::MIME, x) = Base64.base64encode(verbose_show, m, x)
_binstringmime(m::MIME, x::Vector{UInt8}) = Base64.base64encode(write, x)

"""
istextmime(m::MIME)
Expand Down
2 changes: 0 additions & 2 deletions base/stream.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ abstract type LibuvStream <: IO end
# . +- Pipe
# . +- Process (not exported)
# . +- ProcessChain (not exported)
# +- Base64DecodePipe
# +- Base64EncodePipe
# +- BufferStream
# +- DevNullStream (not exported)
# +- Filesystem.File
Expand Down
Loading