-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
constructors for Matrix and SparseMatrixCSC from UniformScaling #24372
Conversation
aaf3582
to
8fd2325
Compare
Ref. #23156 (comment), suggesting special-casing |
As mentioned in #23156, I don't think it is necessary to return |
Cleaned up the existing commits and added a couple commits providing the convenience forms suggested by This pull request should be in shape. Absent objections or requests for time, I am inclined to move forward with this approach (merge) in the next day or two. Thoughts? Thanks! |
Thanks all! |
This pull request provides constructors for
Matrix
andSparseMatrixCSC
fromUniformScaling
s, for exampleMatrix(I, dims)
andSparseMatrixCSC(I, dims)
. In other words, this pull request explores the intersection of #11557 (particularly #11557 (comment)) and #23156. So far this approach feels nice, supporting the direction in #11557 (comment). Best!