Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and specialize equality comparison with UniformScaling #24380

Merged
merged 1 commit into from
Oct 30, 2017
Merged

fix and specialize equality comparison with UniformScaling #24380

merged 1 commit into from
Oct 30, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Oct 28, 2017

== comparison of AbstractMatrixs with UniformScaling fails on master (though ≈ works) by nature of falling back to ===. This pull request provides the necessary generic == methods as well as a specialization for StridedMatrixs. Best!

@Sacha0 Sacha0 added arrays [a, r, r, a, y, s] bugfix This change fixes an existing bug linear algebra Linear algebra labels Oct 28, 2017
@Sacha0
Copy link
Member Author

Sacha0 commented Oct 29, 2017

Absent objections or requests for time, I plan to merge these changes tomorrow. Best!

@fredrikekre fredrikekre merged commit 75d95f9 into JuliaLang:master Oct 30, 2017
@Sacha0 Sacha0 deleted the equalsI branch October 30, 2017 17:08
@Sacha0
Copy link
Member Author

Sacha0 commented Oct 30, 2017

Thanks all! :)

@dalum dalum mentioned this pull request Nov 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s] bugfix This change fixes an existing bug linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sacha0 @fredrikekre