RNG: delete rand_ui* functions in favor of multi-dispatch #25004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
force-pushed
the
rf/rand/UInt52
branch
from
74d3fc4 to
8ee3596
Compare
This special implementation was coupled to MersenneTwister, but there is no reason to not make it more generally available through the Sampler mechanism.
rfourquet
force-pushed
the
rf/rand/UInt52
branch
from
8ee3596 to
101cdc5
Compare
|
I rebased on top of #25002, and I plan to merge both PR later today, if no objection of course, as I would like to get a couple more PR in on the random code before the feature freaze (they would change the random streams so are breaking). |
* we add a first RNG trait, rng_native_52(), which selects a native primitive, between UInt64 and Float64. This is still experimental, but it already allows a little bit of code simplification; * we also rename the rand_generic functions to rand; the "Sampler" framework plus traits should make them un-necessary
rfourquet
force-pushed
the
rf/rand/UInt52
branch
from
101cdc5 to
3c65a84
Compare
|
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rng_native_52(), which selects a nativeprimitive, between
UInt64andFloat64. This is still experimental,but it already allows a little bit of code simplification;
rand_genericfunctions to rand; theSamplerframework plus traits should make them un-necessary