Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test tolerance dependent on condition number in Bunch-Kaufman test #25103

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Make test tolerance dependent on condition number in Bunch-Kaufman test #25103

merged 1 commit into from
Dec 15, 2017

Conversation

andreasnoack
Copy link
Member

Fixes #25096

@andreasnoack andreasnoack added domain:linear algebra Linear algebra test This change adds or pertains to unit tests labels Dec 15, 2017
@rfourquet
Copy link
Member

If this can help, this error can be seen on CI, with RNG seed 0x48c527989c99cb3db9f41553cee8fc9e.

rfourquet
rfourquet reviewed Dec 15, 2017
View reviewed changes
test/linalg/bunchkaufman.jl Outdated
@@ -19,7 +19,7 @@ a2img = randn(n,n)/2
breal = randn(n,2)/2
bimg = randn(n,2)/2

@testset "$eltya argument A" for eltya in (Float32, Float64, ComplexF32, ComplexF64, Int)
@testset "$eltya argument A" for eltya in (Float32, Float64, Complex64, Complex128, Int)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slowly reverting the Complex renaming PR? 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

This was referenced Dec 15, 2017
Merged
Merged
Sacha0
Sacha0 approved these changes Dec 15, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo AV i686 signoff! Thanks @andreasnoack! :)

@vchuravy vchuravy merged commit e3b01be into master Dec 15, 2017
@Sacha0 Sacha0 deleted the anj/25096 branch December 15, 2017 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfourquet rfourquet rfourquet left review comments

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
domain:linear algebra Linear algebra test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreasnoack @rfourquet @Sacha0 @vchuravy