-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move searchsorted* functions to SortedSearch stdlib module #25133
Conversation
In my opinion this feels way to specific to be a stdlib module. |
Yeah, it's not a lot of functionality for a single module. So would you recommend moving them to a package (new or existing) instead? |
Keep them under Base.Sorted but unexported, since they are used in a few places in Base, in particular for sparse vectors and matrices.
717a231
to
2e99780
Compare
Why do you hate these functions so much? :) |
It's just that they don't follow the naming pattern used for all There's also the possibility of merging them with standard |
If it is "just that they don't follow the naming pattern" can't they just be renamed then? As to a sorted wrapper, if it is only used for dispatch, it seems to not solve any concrete problem but add additional ones. |
Yes, renaming them as another option. (Note that I had initially made this PR in the perspective of merging all breaking changes around December 15th, considering that it was simpler to move things to sdlib when we didn't have time to discuss these issues in depth. But since we took that design discussion time, it may not be the most appropriate action now.) |
I've opened #25414 implementing the less radical approach of renaming these functions. |
Keep them under
Base.Sorted
but unexported, since they are used in a few places in Base, in particular for sparse vectors and matrices.Fixes #24883.