Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change similar(::AbstractSet) to empty(::AbstractSet) #25224

Merged
merged 1 commit into from
Dec 24, 2017
Merged

Conversation

rfourquet
Copy link
Member

This seems like a logic extension of #24390.
cc @andyferris

@rfourquet rfourquet added collections Data structures holding multiple items, e.g. sets deprecation This change introduces or involves a deprecation labels Dec 21, 2017
@andyferris
Copy link
Member

Great idea! I thought of this at the time, but completely forgot to follow up (sorry).

@rfourquet
Copy link
Member Author

Given similar was already deprecated for Dict, this change seems uncontroversial, so I will merge. The CI errors are un-related (timeout and 1 "TwicePrecision" failure).

@rfourquet rfourquet merged commit ebc2493 into master Dec 24, 2017
@rfourquet rfourquet deleted the rf/set-similar branch December 24, 2017 12:02
stevengj added a commit to JuliaPackaging/BinDeps.jl that referenced this pull request Aug 14, 2018
`similar(env::AbstractDict)` is deprecated in favor of `empty(env)` in 0.7 (JuliaLang/julia#25224).  There is no Compat support for this, it seems, but this particular call site could be changed to use `copy`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collections Data structures holding multiple items, e.g. sets deprecation This change introduces or involves a deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants