Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in retry check doc string #25355

Closed
wants to merge 1 commit into from

Conversation

tanmaykm
Copy link
Member

@tanmaykm tanmaykm commented Jan 2, 2018

fixes #25351

The retry check function is expected to return a tuple of state and boolean

@tanmaykm tanmaykm force-pushed the tan/fix25351 branch 2 times, most recently from f131c38 to dbafd0b Compare January 2, 2018 12:28
@tanmaykm tanmaykm changed the title fix typo in retry check fix typo in retry check doc string Jan 2, 2018
@tanmaykm tanmaykm added the domain:docs This change adds or pertains to documentation label Mar 19, 2019
fixes JuliaLang#25351

The retry check function is expected to return a tuple of state and boolean

[ci skip]
@kshyatt
Copy link
Contributor

kshyatt commented Oct 22, 2019

Back from the grave just in time for Halloween, can someone review this?

@ViralBShah
Copy link
Member

@tanmaykm Can you please merge this if it is good to go and correct now?

@tanmaykm
Copy link
Member Author

tanmaykm commented May 1, 2020

Looks like this is not needed anymore. The retry function can now handle check functions that return either tuples or just a bool (done in #26138).

Closing this.

@tanmaykm tanmaykm closed this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug or incorrect documentation for retry method?
3 participants