Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AbstractVecOrMat fallback for vcat #25777

Merged
merged 1 commit into from
Jan 28, 2018
Merged

add AbstractVecOrMat fallback for vcat #25777

merged 1 commit into from
Jan 28, 2018

Conversation

stevengj
Copy link
Member

Fixes #25770, which was due to a missing fallback accidentally calling the UniformScaling method.

@ararslan ararslan added the bugfix This change fixes an existing bug label Jan 27, 2018
@JeffBezanson JeffBezanson merged commit 3a27e01 into JuliaLang:master Jan 28, 2018
@stevengj stevengj deleted the vcat_AbstractVecOrMat branch January 28, 2018 04:41
ararslan pushed a commit that referenced this pull request Apr 26, 2018
@stevengj @ararslan
add AbstractVecOrMat fallback for vcat (fixes #25770) (#25777)
7e9a1b8 
Ref #25777
(cherry picked from commit 3a27e01)
ararslan pushed a commit that referenced this pull request Apr 26, 2018
@stevengj @ararslan
add AbstractVecOrMat fallback for vcat (fixes #25770) (#25777)
c4109dc 
Ref #25777
(cherry picked from commit 3a27e01)
@ararslan ararslan mentioned this pull request May 4, 2018
Merged
7 tasks
ararslan pushed a commit that referenced this pull request May 11, 2018
@stevengj @ararslan
add AbstractVecOrMat fallback for vcat (fixes #25770) (#25777)
129f685 
Ref #25777
(cherry picked from commit 3a27e01)
ararslan pushed a commit that referenced this pull request May 27, 2018
@stevengj @ararslan
add AbstractVecOrMat fallback for vcat (fixes #25770) (#25777)
72c3e62 
Ref #25777
(cherry picked from commit 3a27e01)
ararslan added a commit that referenced this pull request Jun 20, 2018
@ararslan
Revert "add AbstractVecOrMat fallback for vcat (fixes #25770) (#25777)"
24c3674 
This reverts commit 3a27e01.
As noted in #27652, this change is breaking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevengj @JeffBezanson @ararslan