Remove broken replace() tests #25851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are incorrect since dce9d05, as nothing is no longer treated as a special value and Some(nothing) cannot be stored in an Array{Union{Int, Nothing}}.
nalimilan
force-pushed
the
nl/replacefix
branch
from
724653b to
2426b2d
Compare
ararslan
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are incorrect since dce9d05, as
nothingis no longer treated as a special valueand
Some(nothing)cannot be stored in anArray{Union{Int, Nothing}}.Fixes a failure introduced by #25697, AFAICT because of a conflict introduced since CI run. Cc: @rfourquet