Move docstrings to Unicode stdlib module #25902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
commented
Feb 5, 2018
| @@ -107,7 +107,7 @@ pointer(x::SubString{String}, i::Integer) = pointer(x.string) + x.offset + (i-1) | |||
| Reverses a string. Technically, this function reverses the codepoints in a string and its | |||
| main utility is for reversed-order string processing, especially for reversed | |||
| regular-expression searches. See also [`reverseind`](@ref) to convert indices in `s` to | |||
| indices in `reverse(s)` and vice-versa, and [`Unicode.graphemes`](@ref Base.Unicode.graphemes) to | |||
| indices in `reverse(s)` and vice-versa, and `graphemes` from module `Unicode` to | |||
There was a problem hiding this comment.
I couldn't get the link to work, suggestions welcome.
There was a problem hiding this comment.
Did [`Unicode.graphemes`](@ref)not work?
There was a problem hiding this comment.
I think it is fine to leave it like this then until we figure it out,
There was a problem hiding this comment.
Yeah, anyway I don't have any solution to suggest. Merge then?
There was a problem hiding this comment.
Sure, perhaps run docs locally and see if it looks OK? Otherwise, looks good to me.
There was a problem hiding this comment.
They look OK, just the link isn't there (obviously :-).
nalimilan
added
unicode
Functions need to be defined in Unicode module, as reexporting Base.Unicode functions makes them appear with the latter prefix in the manual. Also fix examples by fully qualifying Unicode.normalize().
nalimilan
force-pushed
the
nl/unicodedocs
branch
from
d62b2e7 to
958db25
Compare
|
Bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions need to be defined in Unicode module, as reexporting Base.Unicode
functions makes them appear with the latter prefix in the manual.