Deprecate assert function.
#26194
Merged
Deprecate assert function.
#26194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twadleigh
force-pushed
the
tw/deprecate-assert-function
branch
from
dba04a9 to
0c62376
Compare
twadleigh
commented
Feb 24, 2018
| @@ -168,7 +168,7 @@ struct IOContext{IO_t <: IO} <: AbstractPipe | |||
| dict::ImmutableDict{Symbol, Any} | |||
|
|
|||
| function IOContext{IO_t}(io::IO_t, dict::ImmutableDict{Symbol, Any}) where IO_t<:IO | |||
| assert(!(IO_t <: IOContext)) | |||
| @assert !(IO_t <: IOContext) "Cannot create `IOContext` from another `IOContext`." | |||
There was a problem hiding this comment.
Had to add a message here to keep the build happy.
twadleigh
force-pushed
the
tw/deprecate-assert-function
branch
from
0c62376 to
a4833a5
Compare
twadleigh
changed the title
assert function. Addresses #8856.assert function.
twadleigh
force-pushed
the
tw/deprecate-assert-function
branch
4 times, most recently
from
1329134 to
912ad04
Compare
twadleigh
commented
Feb 25, 2018
| depwarn("`assert` is deprecated, use `@assert` instead.", :assert) | ||
| @assert x "" | ||
| end | ||
|
|
There was a problem hiding this comment.
I didn't use vanilla @deprecate because the resulting warning message was a little mangled.
twadleigh
force-pushed
the
tw/deprecate-assert-function
branch
2 times, most recently
from
dbebb37 to
2ee03b1
Compare
twadleigh
force-pushed
the
tw/deprecate-assert-function
branch
from
2ee03b1 to
96813aa
Compare
JeffBezanson
approved these changes
Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8856. Tests pass locally for me.
The deprecation warning message is currently mangled.The warning looks like: