Remove outdated reference to embedding Makefile #26214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file moved from examples/embedding to test/embedding in #26123 but updates to the examples Makefile where erroneously omitted.
ararslan
added
building
|
Shouldn't the entire |
|
True. The file is removed anyway as part of #26153. |
|
Let's just merge #26153 then? |
|
That sounds good to me, just need to figure out the doc installation issue with that PR. |
|
It looks like #26153 will take a bit more time. Should we just merge this? It's a bit silly to block fixing the most urgent problem we have on moving the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file moved from examples/embedding to test/embedding in #26123 but updates to the examples Makefile where erroneously omitted.
Ref #26123 (comment).