fresh variables on each iteration in nested loop and generator syntax #26483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
breaking
JeffBezanson
force-pushed
the
jb/loopnests
branch
from
39ab43a to
fde84a3
Compare
JeffBezanson
force-pushed
the
jb/loopnests
branch
from
fde84a3 to
0709cb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the plus side, I get to close a 3-digit issue. On the minus side, that is some grödy lowering 😁
I think these cases are rare enough that we can live without a deprecation. It's a small miracle that the deprecation for the other loop scope change still works with this. But there is a strange interaction: for all but the innermost loop variable, you can still get scope deprecation warnings, but you can't assign to the outer variable from the loop body (unless it's declared
outer).fixes #330