add dump method for Ptr #26880
Merged
add dump method for Ptr #26880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
needs tests
|
There are tests for |
Currently `dump(x::Ptr)` will print the type of the pointer twice, e.g.
```Ptr{Nothing} Ptr{Nothing} @0x0000000120f1d2d0```
This adds an overload so that it only prints once.
|
FreeBSD failure is the same as in #27075, which suggests that it may not be such a "low-probability" failure anymore (perhaps due to some other change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
dump(x::Ptr)will print the type of the pointer twice, e.g.Ptr{Nothing} Ptr{Nothing} @0x0000000120f1d2d0This was because the catchall
dumpmethod first printedtypeof(x), thenxitself, and theprintmethod forPtralso prints the type first. This PR adds an overload so that the pointer type is only printed once.Ptr{Nothing} @0x0000000120f1d2d0I believe
dumpis not really exercised in tests right now but I could add some?