Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop setting force_noinline for functions of union arguments #27057

Merged
merged 1 commit into from
Sep 14, 2020

Commits on Sep 14, 2020

  1. Stop setting force_noinline for function of union arguments

    The original motivation for setting force_noinline for functions
    with union arguments seems to have been bugs in type intersection.
    However, the type system has improved quite a bit and at least in
    the test suites we don't seem to run into any issues. Thus, we can
    stop setting force_noinline. Nevertheless, it still make since
    to penalize functions with union arguments. Doing so encourages
    union splits to happen at the call site, rather than having multiple
    redundant union splits inside the function. However, for simple functions
    of intrinsics and builtins it can make a lot of sense to inline
    the union split signature.
    Keno committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    fa4d0d7 View commit details
    Browse the repository at this point in the history