-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade OpenBLAS to 0.3.0 #27221
upgrade OpenBLAS to 0.3.0 #27221
Conversation
da7ae93
to
595f094
Compare
Will the ci systems build openblas? |
Note this also updates to lapack 3.8 |
FreeBSD died on Distributed. Appveyor looks like it might have timed out. |
Restarted Appveyor build, but not sure if it will help. |
This might also benefit from #27222 |
Should we merge #27222 and rebase this on top of that? |
595f094
to
0f7eb6e
Compare
Need to update the checksums. |
All of Travis stalled out. I was thinking that it might have been an issue with their infrastructure, but there is no report. IIUC AV doesn't build OpenBLAS since it uses the prebuilt binaries. I kicked of some buildbot runs, but that this point our queue is 18h behind. |
Pushed the checksums. |
5fcc6d3 already had the checksums |
Would it make sense to start using https://github.com/staticfloat/OpenBLASBuilder/ instead of building these here? |
For Appveyor yes, since currently IIUC we are using the dll from the nightly. (I won't be the person to change us to OpenBLASBuilder, though I have my hands full enough as it is) |
@vchuravy I think I had an older branch, which is why I didn't see your checksum commit. Should have pulled. |
How do we know whether the windows buildbot successfully built openblas 0.3 last night and that is being picked up here? The appveyor build logs seem to not have any indicating information about openblas. |
The buildbot builds haven even started yet, and they won't be used for the nightly. I would propose waiting for them to go through and then merging this. At least I am not seeing any testfailures that are LinAlg related. |
5d9f60a
to
8ddb567
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This should fix #16653, JuliaLang/LinearAlgebra.jl#501, #25266 when merged. |
I am marking as backport for 0.6.3 if @ararslan will allow it, as it will fix outstanding mac performance issues for 0.6 reported in the issues above. |
I'd like to freeze the 0.6.3 backports at this point, otherwise it risks continuously amassing new commits while I try to resolve the one remaining issue. |
Just because I'm curious: @nanosoldier |
|
Will nanosoldier build openblas 0.3 on this branch? |
Yes nanosoldier doesn't use any caching besides ccache. |
8ddb567
to
649ac0c
Compare
@nanosoldier |
Nanosoldier is broken right now and I haven't yet figured out why. |
Do we really need this on the 0.7 milestone? We can do this any time, given that it is completely non-breaking. I will also note that in reality, it should be easy to merge this shortly. |
We'll probably have openblas 0.3.1 by the time we release Julia 0.7. I have not yet seen anything major, and this looks like a good openblas release. |
0.3.0 was released just recently and it has some improvement w.r.t to performance on Mac OSX.