Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update world age between packages in e.g. using A, B #27549

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

JeffBezanson
Copy link
Member

@andreasnoack andreasnoack merged commit 8d7de0f into master Jun 13, 2018
@andreasnoack andreasnoack deleted the jb/worldageusing branch June 13, 2018 07:36
@colintbowers
Copy link

It's possible that this will also fix #21653. I was able to trigger/fix #21653 by combining/uncombining using statements.

@ararslan ararslan mentioned this pull request Jun 17, 2018
3 tasks
@ararslan
Copy link
Member

Jeff says this likely doesn't apply to 0.6, since the issue does not appear possible on 0.6 due to differences in how this is handled between 0.6 and 0.7. @colintbowers, when you say you were able to trigger the issue, was that with 0.6 or 0.7?

@ararslan
Copy link
Member

I'll remove the backport label for now, but if someone is certain that this fixes a known issue on 0.6 specifically then let me know.

@colintbowers
Copy link

@ararslan v0.6.2 (sorry should have included that), so sounds like the two are unrelated. Just thought I'd mention it given that both are world age issues that can be caused by combining/uncombining using. Thanks anyway.

@ararslan
Copy link
Member

So I guess this is indeed an issue on 0.6 but perhaps this PR is not the solution that resolves it on 0.6.

@JeffBezanson
Copy link
Member Author

That's really strange; in 0.6.x using A, B is lowered directly to two separate toplevel using statements.

@colintbowers
Copy link

colintbowers commented Jun 18, 2018

Agreed that makes my "fix" all the weirder. On the plus side, I haven't encountered #21653 at all on v0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants