Add a do-block form of the CachingPool #27683
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels right.
Generally I think there is some region of code in which the cached functions need to be keep.
So a do-block form that runs the function,
then when done
clear!
s the pool seems right.I guess maybe not required as the finalizer will clean up once the pool get garbage collected.
But given that the reason you are using a
CachingPool
in the first place is because you are worried that you have huge closures being passed around,clearing sooner is better than latter.
This needs tests I guess, but I figured I'ld wait and see if the idea was sound