Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a do-block form of the CachingPool #27683

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oxinabox
Copy link
Contributor

This feels right.

Generally I think there is some region of code in which the cached functions need to be keep.
So a do-block form that runs the function,
then when done clear!s the pool seems right.

I guess maybe not required as the finalizer will clean up once the pool get garbage collected.
But given that the reason you are using a CachingPool in the first place is because you are worried that you have huge closures being passed around,
clearing sooner is better than latter.

This needs tests I guess, but I figured I'ld wait and see if the idea was sound

@oxinabox
Copy link
Contributor Author

oxinabox commented Jun 24, 2018

A.V has 64 bit failure with

Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
Exception: EXCEPTION_ACCESS_VIOLATION at 0x680b3d78 -- gc_mark_loop at /cygdrive/c/projects/julia/src\gc.c:1858
in expression starting at C:\projects\julia\usr\share\julia\stdlib\v0.7\Pkg\src\precompile.jl:75
gc_get_stack_addr at /cygdrive/c/projects/julia/src\gc.c:1351 [inlined]
gc_read_stack at /cygdrive/c/projects/julia/src\gc.c:1358 [inlined]

during precompilation.

CircleCI failed during make for reasons that I can't see displayed

@martinholters
Copy link
Member

The AV failure is probably because it was run prior to #27702, the "Killed" on Circle is usually OOM, IIUC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants