fix #27710, scope error with static param. and variable name conflicts #27760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
compiler:lowering
| struct Foo27710{T} end | ||
| function test27710() | ||
| types(::Foo27710{T}) where T = T | ||
| T = types(Foo27710{Int64}()) |
Member
There was a problem hiding this comment.
This is a pretty inscrutable test. Is assigning this particular value to T significant or is it just the fact that something is being assigned to it that's important?
Member
Author
There was a problem hiding this comment.
Both. The inner function needs to work, and the assigned variable here needs to be called T.
Member
There was a problem hiding this comment.
Right, but you could do something like this instead, right:
T = nothing
types(::Foo27710{T}) where T = T
return types(Foo27710{Int64}())
Member
Author
There was a problem hiding this comment.
Sure, or even better return (T, types(Foo27710{Int64}())), to make sure the assignment works too. But it seems like a pretty minor point to me.
Member
There was a problem hiding this comment.
I was just trying to understand it, not complain 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic issue here was that
resolve-scopeswas not aware of static parameters. Typically it would mark them asouterref, but if an enclosing scope had a variable with the same name then it wouldn't. I decided that static parameters are more local, so I switched to always leaving them as bare symbols and adding them to a lambda's local environment.