Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statistics #27834

Merged
merged 2 commits into from
Jun 29, 2018
Merged

Statistics #27834

merged 2 commits into from
Jun 29, 2018

Conversation

fredrikekre
Copy link
Member

No description provided.

@fredrikekre fredrikekre added the stdlib Julia's standard library label Jun 27, 2018
@andreasnoack
Copy link
Member

andreasnoack commented Jun 28, 2018 •
edited
Loading

It looks like the doc tests are failing or at least need to be adjusted a bit.

@fredrikekre fredrikekre force-pushed the fe/movebackstatisticstostdliborhowtopleasethemasses branch from bf10ad9 to ca5cd12 Compare June 28, 2018 06:52
@fredrikekre fredrikekre reopened this Jun 28, 2018
@ViralBShah
Copy link
Member

Should we rename the functions to remove the things with m suffixes (maybe in a separate PR) and really consider not using up 3 letter names for std and var?

@vchuravy
Copy link
Member

No std and var are fine and this in the Statistics namespace. I am in favour of merging this quickly.

@StefanKarpinski
Copy link
Member

Agree, now that this is all in a package in a place where people can still get at it easily, we have the ability to improve and evolve this API outside of Base without everyone being up in arms about it.

@mbauman
Copy link
Member

mbauman commented Jun 28, 2018

What's the plan with regards to StatsBase?

@quinnj
Copy link
Member

quinnj commented Jun 28, 2018

We can selectively move stuff from StatsBase.jl to here; it will be a good cleanup/fine-tuning of functionality there anyway.

@JeffBezanson
Copy link
Member

Oops, caused a conflict here, sorry.

@simonbyrne simonbyrne force-pushed the fe/movebackstatisticstostdliborhowtopleasethemasses branch from ca5cd12 to 4301009 Compare June 28, 2018 19:47
@simonbyrne
Copy link
Contributor

I've rebased.

@JeffBezanson JeffBezanson merged commit 91a8de2 into master Jun 29, 2018
@JeffBezanson JeffBezanson deleted the fe/movebackstatisticstostdliborhowtopleasethemasses branch June 29, 2018 04:44
@JeffBezanson JeffBezanson mentioned this pull request Jun 29, 2018
Closed
This was referenced Jun 29, 2018
Merged
Closed
@brenhinkeller brenhinkeller mentioned this pull request Oct 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson approved these changes

@vchuravy vchuravy vchuravy approved these changes

Assignees
No one assigned
Labels
stdlib Julia's standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@fredrikekre @andreasnoack @ViralBShah @vchuravy @StefanKarpinski @mbauman @quinnj @JeffBezanson @simonbyrne