Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kw args to squeeze deprecation #28374

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Add kw args to squeeze deprecation #28374

merged 1 commit into from
Jul 31, 2018

Conversation

Keno
Copy link
Member

@Keno Keno commented Jul 31, 2018

Just @deprecate doesn't pass through keyword arguments. @deprecate_binding seems more appropriate for a renaming.

@Keno Keno requested a review from JeffBezanson July 31, 2018 17:52
@fredrikekre
Copy link
Member

fredrikekre commented Jul 31, 2018

Perhaps add ; kwargs... here instead

:(function $(esc(old))(args...)
$(esc(new))(args...)

The problem with @deprecate_binding is that it usually don't give you a very good estimate of where the deprecation comes from, and makes it difficult to find them (see e.g. #26919 (comment), #26919 (comment))

@Keno
Copy link
Member Author

Keno commented Jul 31, 2018

That's fine with me also, but it's a more invasive change, which I didn't want to have to go through testing with before the rc. I guess we could also just do @deprecate squeeze(args...; kwargs...) dropdims(args...; kwargs...). Let me do that and get this in.

@Keno Keno changed the title Deprecate squeeze using deprecate_binding Add kw args to squeeze deprecation Jul 31, 2018
@Keno Keno added this to the 0.7 milestone Jul 31, 2018
@ararslan ararslan mentioned this pull request Jul 31, 2018
13 tasks
@Keno Keno merged commit 40f8468 into master Jul 31, 2018
@fredrikekre fredrikekre deleted the kf/squeezebinding branch July 31, 2018 20:28
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants