emit precompile statements to separate file #28419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
approved these changes
Aug 3, 2018
if the filename to trace--compile is stdout, print to the stdout stream
KristofferC
force-pushed
the
kc/emit_file_precompile
branch
from
f3edd02 to
d1be419
Compare
ararslan
pushed a commit
that referenced
this pull request
Aug 3, 2018
if the filename to trace--compile is stdout, print to the stdout stream (cherry picked from commit cfc7475)
KristofferC
added a commit
that referenced
this pull request
Feb 11, 2019
if the filename to trace--compile is stdout, print to the stdout stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emitting precompile statements directly to stdout is a bit brittle when other things also can print to there. This can cause failures when precompile statements gets interleaved with other stderr output (e.g. CI failure here https://build.julialang.org/#/builders/93/builds/526).
Instead, emit these statements to a separate file by setting
--trace-compile=file. For convenience,--trace-compile=stderrstill prints to stderr since it can be a useful inspection tool.Good to look at diff with whitespace turned off because a
mktempchanged an indentation.Thanks to @Keno for help.