Avoid possible shredding of passed credential on reject #28448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omus
added
libgit2
mbauman
approved these changes
Aug 4, 2018
ararslan
pushed a commit
that referenced
this pull request
Aug 5, 2018
(cherry picked from commit 696700f)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a very minor issue with #28436. In the event the credentials should be rejected the
CachedCredentialcould shred the passed in credential if it happened to be identical to the one stored within the cache. Probably no one would have noticed this in practise but at worst it would have resulted in us sending invalid credentials to servers.I also added more comments as this code is complicated and subtle.