Update usage for build_sysimg.jl #28970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done so this is present in the documented location for source builds
|
Note: building sysimgs is still broken. |
|
I wonder if we can get rid of this file and have all the focus on PackageCompiler.jl. This was a stopgap file until something more serious existed. Or alternately, bring PackageCompiler into this repo and make it first class. |
|
It's not clear to me how to replicate this functionality with PackageCompiler. Maybe In any case no one has paid any attention to PackageCompiler either, as it doesn't build on 1.0. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ended up having to make some 1.0 updates to the code and add a Makefile target so it's present in the documented directory when Julia is built.