Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix History eye deprecation PR: should be 24415 #28977

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Aug 30, 2018

The History.md file linked to #24413 for eye deprecation in 0.7. This commit changes it to link to #24415.

It looks like it was a typo, since 24413 was already used on that page, and is about deprecating fill!. I think 24415 is the correct new number, but i'm not 100% positive.

The History.md file linked to JuliaLang#24413 for `eye` deprecation in 0.7. This commit changes it to link to JuliaLang#24415.
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Great catch! Much thanks @NHDaly! :)

Absent objections, requests for time, or someone beating me to it, I plan to merge this change this evening PT or later. Best!

@ararslan
Copy link
Member

This should be applied to the release-0.7 branch if we're to do another 0.7.x release (seems unnecessary but who knows), but it'll have to be manually backported as the change in 0.7 should go to NEWS.md rather than HISTORY.md.

@Sacha0 Sacha0 merged commit 804d12e into JuliaLang:master Aug 31, 2018
@Sacha0
Copy link
Member

Sacha0 commented Aug 31, 2018

Thanks @NHDaly! :)

@NHDaly NHDaly deleted the patch-2 branch August 31, 2018 10:09
@NHDaly
Copy link
Member Author

NHDaly commented Aug 31, 2018

👍!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants