stdlib/SparseArrays: fix scalar setindex! for vector eltype #29331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appveyor failure seems unrelated |
|
Can we merge this? |
stev47
force-pushed
the
fix-sparsevec
branch
from
dc79628 to
c59c398
Compare
|
Just rebased the branch: to me the appveyor failure does not seem to be related |
mbauman
reviewed
Dec 19, 2018
| @@ -2565,7 +2569,8 @@ end | |||
| _to_same_csc(::SparseMatrixCSC{Tv, Ti}, V::AbstractMatrix, I...) where {Tv,Ti} = convert(SparseMatrixCSC{Tv,Ti}, V) | |||
| _to_same_csc(::SparseMatrixCSC{Tv, Ti}, V::AbstractVector, I...) where {Tv,Ti} = convert(SparseMatrixCSC{Tv,Ti}, reshape(V, map(length, I))) | |||
|
|
|||
| setindex!(A::SparseMatrixCSC{Tv}, B::AbstractVecOrMat, I::Integer, J::Integer) where {Tv} = setindex!(A, convert(Tv, B), I, J) | |||
| setindex!(A::SparseMatrixCSC{Tv}, B::AbstractVecOrMat, I::Integer, J::Integer) where {Tv} = _setindex_scalar!(A, B, I, J) | |||
There was a problem hiding this comment.
I was hoping we might be able to remove this method entirely, but it looks like it's disambiguating against the method that immediately follows. Using a helper function like this is a good solution.
mbauman
approved these changes
Dec 19, 2018
StefanKarpinski
added
backport 1.1
triage
|
Should this be backported to 1.0 too? The issue is also present in 1.0.3. |
|
Yes, I'd support backporting it — it's a fairly major bugfix. |
|
Ping. I run into this, I believe on Julia Version 1.1.0: |
|
probably because this pull request has not yet been backported |
55 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
KristofferC
pushed a commit
that referenced
this pull request
Aug 27, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #29034
There might be more elegant solutions, I'm open to suggestions.