-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jldoctest example in mapreduce(...) #29604
Conversation
Yes, they are indeed supposed to be checked and the log suggest they are, e.g. https://travis-ci.org/JuliaLang/julia/jobs/439252959#L3548. If they are actually not running then that is bad and need fixing. |
I see, thanks. |
I don't think this particular docstring is included in the manual. I can only find https://docs.julialang.org/en/v1.1-dev/base/collections/#Base.mapreduce-Tuple{Any,Any,Any} If it is not spliced into the manual then it does not get tested (a behaviour which I am planning to change with JuliaDocs/Documenter.jl#774). |
Thanks, that explains it: indeed, it seems that hardly any of the array functionality from |
No, do you feel like adding it? |
Sure; I can make a PR for that some time next week, probably. (Or add it to this one, but I guess it's more meaningful to separate it out) |
Just add it to this one when you get time. |
(cherry picked from commit 3b7be23)
(cherry picked from commit 3b7be23)
(cherry picked from commit 3b7be23)
Previously, the example produced an error, as no such method exists; just a typo I imagine.
Out of curiosity: isn't it the intention of
```jldoctest ...```
that documentation-examples such as this one would be automatically checked and caught by Documenter.jl's doctests?