Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two documentation updates #30049

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Two documentation updates #30049

merged 1 commit into from
Nov 30, 2018

Conversation

fingolfin
Copy link
Member

  • require takes to arguments
  • jl_new_uniontype does not exist anymore

@fingolfin
Two documentation updates
883c271 
* `require` takes to arguments
* `jl_new_uniontype` does not exist anymore
StefanKarpinski
StefanKarpinski approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the change to the loading docs. Someone else will need to approve the dev docs. Presumable the jl_new_uniontype function was deleted at some point?

@fingolfin
Copy link
Member Author

Yes, I checked via git log -G jl_new_uniontype. As far as I could tell, now one just uses jl_apply_type in its place.

(We discovered both of these as well as #30019 while working on our interface between GAP and Julia)

@fingolfin
Copy link
Member Author

I don't want to be annoying, but: What do we have to do in order to get this documentation fix merged?

@fredrikekre fredrikekre added the docs This change adds or pertains to documentation label Nov 30, 2018
@fredrikekre fredrikekre merged commit ef496b0 into JuliaLang:master Nov 30, 2018
@fingolfin
Copy link
Member Author

Thank you!

@fingolfin fingolfin deleted the mh/fix-docs branch November 30, 2018 10:41
KristofferC pushed a commit that referenced this pull request Dec 6, 2018
@fingolfin @KristofferC
Two documentation updates (#30049)
8f2eb31 
* `require` takes to arguments
* `jl_new_uniontype` does not exist anymore

(cherry picked from commit ef496b0)
@KristofferC KristofferC mentioned this pull request Dec 6, 2018
Merged
61 tasks
KristofferC pushed a commit that referenced this pull request Dec 12, 2018
@fingolfin @KristofferC
Two documentation updates (#30049)
8deac44 
* `require` takes to arguments
* `jl_new_uniontype` does not exist anymore

(cherry picked from commit ef496b0)
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@fingolfin @KristofferC
Two documentation updates (#30049)
9aea9d3 
* `require` takes to arguments
* `jl_new_uniontype` does not exist anymore

(cherry picked from commit ef496b0)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@fingolfin @KristofferC
Two documentation updates (#30049)
b017afe 
* `require` takes to arguments
* `jl_new_uniontype` does not exist anymore

(cherry picked from commit ef496b0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fingolfin @StefanKarpinski @fredrikekre