Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make broadcast_axes inferrable even if axes are of different types #30074

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Make broadcast_axes inferrable even if axes are of different types #30074

merged 1 commit into from
Nov 20, 2018

Conversation

timholy
Copy link
Member

@timholy timholy commented Nov 18, 2018

This was originally discovered as JuliaArrays/StaticArrays.jl#546 but there's a non-static fix needed too. This uses OneTo and UnitRange as the default fallbacks.

@timholy timholy mentioned this pull request Nov 18, 2018
Merged
@ararslan ararslan requested a review from mbauman November 20, 2018 16:34
@mbauman mbauman merged commit 6e1464b into master Nov 20, 2018
@KristofferC
Copy link
Member

Backport?

@fredrikekre fredrikekre deleted the teh/bcast_axes_infer branch November 20, 2018 16:58
@timholy
Copy link
Member Author

timholy commented Nov 20, 2018

Yes, I think so.

timholy added a commit that referenced this pull request Nov 27, 2018
@timholy
Use only safe axis types for Broadcast.combine_axes
1884cb4 
#30074 used the wrong notion of consistency since `OneTo(1)` is
consistent (wrt broadcasting) with any range, but `OneTo` cannot
handle `Slice(-1:1)`.
@timholy timholy mentioned this pull request Nov 27, 2018
Merged
@KristofferC KristofferC mentioned this pull request Nov 28, 2018
Merged
61 tasks
@KristofferC KristofferC added performance Must go faster and removed backport pending 1.0 labels Dec 12, 2018
KristofferC pushed a commit that referenced this pull request Dec 30, 2018
@timholy @KristofferC
Use only safe axis types for Broadcast.combine_axes
160054e 
#30074 used the wrong notion of consistency since `OneTo(1)` is
consistent (wrt broadcasting) with any range, but `OneTo` cannot
handle `Slice(-1:1)`.

(cherry picked from commit 1884cb4)
KristofferC pushed a commit that referenced this pull request Feb 4, 2019
@timholy @KristofferC
Use only safe axis types for Broadcast.combine_axes
b399294 
#30074 used the wrong notion of consistency since `OneTo(1)` is
consistent (wrt broadcasting) with any range, but `OneTo` cannot
handle `Slice(-1:1)`.

(cherry picked from commit 1884cb4)
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@timholy @KristofferC
Use only safe axis types for Broadcast.combine_axes
fcc93a4 
#30074 used the wrong notion of consistency since `OneTo(1)` is
consistent (wrt broadcasting) with any range, but `OneTo` cannot
handle `Slice(-1:1)`.

(cherry picked from commit 1884cb4)
KristofferC pushed a commit that referenced this pull request Aug 26, 2019
@timholy @KristofferC
Use only safe axis types for Broadcast.combine_axes
02634ee 
#30074 used the wrong notion of consistency since `OneTo(1)` is
consistent (wrt broadcasting) with any range, but `OneTo` cannot
handle `Slice(-1:1)`.

(cherry picked from commit 1884cb4)
@KristofferC KristofferC mentioned this pull request Sep 26, 2019
Closed
@c42f c42f mentioned this pull request Feb 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbauman mbauman mbauman approved these changes

Assignees
No one assigned
Labels
performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timholy @KristofferC @mbauman